bbAntiSpam: Discuss how to stop web spam

The forum is retired.

bbAntiSpam Forum Index - Links Rejector - Great app, but a false positive

Author Message
DickS
Guest
Posted: Wed Jul 19, 2006 5:54 am    Post subject: Great app, but a false positive  
Hi,

This is a great app. Installed it and works fine. One question though with following post which was emailed as blocked but still appeared in the forum:

---------------------------------------------------------------------------------

* callto: / / (/ / lines in original post are together, same as below)

Text of the message
===================

User name: , subject:

[quote:da8c37e3e1="peter"]Hi, Yes, that is correct.[/quote:da8c37e3e1] hi hi, please correct me if am wrong but software can only cast just the ONE single file??? it cant read the folder or ftp and make a playlist??? secondly what does callto: / / refer to???

-----------------------------------------------------------------------------------

This is a correct post (callto:-tags are OK), any idea why bbAntiSpam sent a notification on it and the message did get posted?

Keep up the great work, we'll get a license key for this product soon Smile

Cheers!

DickS
admin
Site Admin


Joined: 18 Apr 2006
Posts: 805
Location: Saint-Petersburg, Russia
Posted: Thu Jul 20, 2006 4:36 am    Post subject:  
Hi! Thanks for reporting the issue. But I can interpret it in different ways:
* bug report: bbAntiSpam nofitied that a posting was rejected, but actually the posting appeared in the forum;
* usability report: "callto://" pseudo-URLs shouldn't be blocked.
I think you are annoyed by the second. Am I right?
Guest
Posted: Thu Jul 20, 2006 7:15 am    Post subject:  
admin,

Yes, that is correct. Any way to have these "allowed" without notification emails sent, because it is confusing to get an email that a post has been blocked when it actually has not been blocked.

Or there can be separate "informative" email sent asking to manually check that post?

Cheers and great MOD!

DickS
admin
Site Admin


Joined: 18 Apr 2006
Posts: 805
Location: Saint-Petersburg, Russia
Posted: Fri Jul 21, 2006 3:43 am    Post subject:  
Quote:
bug report: bbAntiSpam nofitied that a posting was rejected, but actually the posting appeared in the forum

I can't reproduce this behaviour. And even can't imagine how it is possible. Most likely, the following have happened:
* your user registered and re-posted the message being registered, or
* the user modified the message a bit (for example, added a whitespace).
Would you please give a link to the user's post? I'll look at it to get an idea.

Quote:
usability report: "callto://" pseudo-URLs shouldn't be blocked.

I'm still thinking on it. First of all, it is considered as a link by phpBB itslef, and I need to workaround it. Second, it gives a chance of links like "callto://spam.com/". Anyway, here is a solution. Edit the file "includes/functions_bbas.php". At the end of file, find
Code:

  return array_unique($ret);
}

and replace it by:
Code:

  $ret = array_unique($ret);
  $ret = array_filter($ret, bbas_link_not_allowed);
  return $ret;
}

//
// Return true if the link is not allowed.
//
function bbas_link_not_allowed($link) {
  //
  // Internals of phpBB convert texts like "lalala://" to links.
  // Actually, they are not spam links:
  // http://bbantispam.com/forum/viewtopic.php?t=30
  //
  if (preg_match('#(\w+)://#', $link, $matches)) {
    $proto = $matches[1];
    $idx = array_search($proto, array('ftp', 'http', 'https', 'mailto', 'news', 'nntp'));
    if (FALSE === $idx) {
      return 0;
    }
  }
  //
  // Otherwise, all links are spam
  //
  return 1;
}


Quote:
Or there can be separate "informative" email sent asking to manually check that post?

In the far future.
DickS
Guest
Posted: Fri Jul 21, 2006 6:54 am    Post subject:  
Great, have ammended the file and uploaded. Lets see what happens Smile

Here the post (by chez): www . pamela-systems . com / forum / viewtopic.php?t=772

It is near the end of the posts.
admin
Site Admin


Joined: 18 Apr 2006
Posts: 805
Location: Saint-Petersburg, Russia
Posted: Sat Jul 22, 2006 1:50 am    Post subject:  
Thanks for the link. I've looked at the post and now relax.That post is written by a registered user ("chaz"). Why bbAntiSpam sent a letter? Because initially the user tried to post as an unregistered user. After he failed, he logged in and posted succesfully.

Thanks for reporting and suggestions!
DickS
Guest
Posted: Sat Jul 22, 2006 3:52 pm    Post subject:  
Cool, you guys have made one of the best Mods for phpBB that I have come accross. This saves a webmaster a TON of work!

A six star rating from me.

Keep up the great work.
admin
Site Admin


Joined: 18 Apr 2006
Posts: 805
Location: Saint-Petersburg, Russia
Posted: Sun Jul 23, 2006 1:45 am    Post subject:  
Thanks for kind words! It's the best incentive for me.

Ok.